Skip to content

Commit

Permalink
CommandLineScanner: Do not require the expected version
Browse files Browse the repository at this point in the history
Do not override `getVersionRequirement()` and instead use the default
implementation which allows any version.

Since 9af81d8 any version of the command line scanners is accepted, the
expected version is only used to bootstrap a scanner if it is not found
on the path. Therefore returning the expected version as a requirement
was wrong.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
  • Loading branch information
mnonnenmacher committed Dec 29, 2021
1 parent eb379a7 commit 1ec0da0
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions scanner/src/main/kotlin/CommandLineScanner.kt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

package org.ossreviewtoolkit.scanner

import com.vdurmont.semver4j.Requirement

import java.io.File
import java.io.IOException

Expand Down Expand Up @@ -102,8 +100,6 @@ abstract class CommandLineScanner(
*/
override val version by lazy { getVersion(scannerDir) }

override fun getVersionRequirement(): Requirement = Requirement.buildLoose(expectedVersion)

/**
* Bootstrap the scanner to be ready for use, like downloading and / or configuring it.
*
Expand Down

0 comments on commit 1ec0da0

Please sign in to comment.