build: Move all VCS plugins to separate Gradle projects

This resolves #6602.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>

cli/build.gradle.kts

@@ -47,6 +47,7 @@ dependencies {
     "pluginClasspath"(platform(project(":plugins:package-managers")))
     "pluginClasspath"(platform(project(":plugins:reporters")))
     "pluginClasspath"(platform(project(":plugins:scanners")))
+    "pluginClasspath"(platform(project(":plugins:version-control-systems")))
 
     funTestImplementation(platform(project(":plugins:commands")))
     funTestImplementation(platform(project(":plugins:package-managers")))

cli/src/funTest/kotlin/AnalyzerFunTest.kt

@@ -29,14 +29,14 @@ import java.util.concurrent.TimeUnit
 import org.ossreviewtoolkit.analyzer.Analyzer
 import org.ossreviewtoolkit.analyzer.PackageManager
 import org.ossreviewtoolkit.analyzer.managers.analyze
-import org.ossreviewtoolkit.downloader.vcs.GitRepo
 import org.ossreviewtoolkit.model.Package
 import org.ossreviewtoolkit.model.VcsInfo
 import org.ossreviewtoolkit.model.VcsType
 import org.ossreviewtoolkit.model.config.AnalyzerConfiguration
 import org.ossreviewtoolkit.model.config.PackageManagerConfiguration
 import org.ossreviewtoolkit.model.config.RepositoryConfiguration
 import org.ossreviewtoolkit.model.toYaml
+import org.ossreviewtoolkit.plugins.versioncontrolsystems.git.GitRepo
 import org.ossreviewtoolkit.utils.test.getAssetFile
 import org.ossreviewtoolkit.utils.test.matchExpectedResult
 import org.ossreviewtoolkit.utils.test.patchActualResult

downloader/build.gradle.kts

@@ -27,17 +27,5 @@ dependencies {
 
     implementation(project(":utils:ort-utils"))
 
-    implementation(libs.jgit)
-    implementation(libs.jgitSshApacheAgent) {
-        exclude(group = "org.apache.sshd", module = "sshd-sftp")
-            .because("it is not required for cloning via SSH and causes issues with GraalVM native images")
-    }
-    implementation(libs.svnkit) {
-        exclude(group = "org.apache.sshd", module = "sshd-core")
-            .because("it is included in JGit's sshd-osgi dependency")
-        exclude(group = "org.apache.sshd", module = "sshd-common")
-            .because("it is included in JGit's sshd-osgi dependency")
-    }
-
     testImplementation(libs.mockk)
 }

downloader/src/main/kotlin/VersionControlSystem.kt

@@ -156,7 +156,7 @@ abstract class VersionControlSystem(
         /**
          * Return glob patterns for files that should be checkout out in addition to explicit sparse checkout paths.
          */
-        internal fun getSparseCheckoutGlobPatterns(): List<String> {
+        fun getSparseCheckoutGlobPatterns(): List<String> {
             val globPatterns = mutableListOf("*$ORT_REPO_CONFIG_FILENAME")
             val licensePatterns = LicenseFilePatterns.getInstance()
             return licensePatterns.allLicenseFilenames.generateCapitalizationVariants().mapTo(globPatterns) { "**/$it" }

downloader/src/test/kotlin/VersionControlSystemTest.kt

@@ -30,10 +30,10 @@ import java.io.File
 import java.io.IOException
 import java.lang.UnsupportedOperationException
 
-import org.ossreviewtoolkit.downloader.vcs.Git
 import org.ossreviewtoolkit.model.Package
 import org.ossreviewtoolkit.model.VcsInfo
 import org.ossreviewtoolkit.model.VcsType
+import org.ossreviewtoolkit.plugins.versioncontrolsystems.git.Git
 import org.ossreviewtoolkit.utils.common.CommandLineTool
 
 class VersionControlSystemTest : WordSpec({

plugins/package-managers/gradle-inspector/src/funTest/kotlin/GradleFunTest.kt

@@ -29,8 +29,8 @@ import io.kotest.matchers.should
 
 import org.ossreviewtoolkit.analyzer.managers.create
 import org.ossreviewtoolkit.analyzer.managers.resolveSingleProject
-import org.ossreviewtoolkit.downloader.vcs.Git
 import org.ossreviewtoolkit.model.toYaml
+import org.ossreviewtoolkit.plugins.versioncontrolsystems.git.Git
 import org.ossreviewtoolkit.utils.common.Os
 import org.ossreviewtoolkit.utils.common.ProcessCapture
 import org.ossreviewtoolkit.utils.test.ExpensiveTag

plugins/package-managers/gradle/src/funTest/kotlin/GradleFunTest.kt

@@ -29,8 +29,8 @@ import io.kotest.matchers.should
 
 import org.ossreviewtoolkit.analyzer.managers.create
 import org.ossreviewtoolkit.analyzer.managers.resolveSingleProject
-import org.ossreviewtoolkit.downloader.vcs.Git
 import org.ossreviewtoolkit.model.toYaml
+import org.ossreviewtoolkit.plugins.versioncontrolsystems.git.Git
 import org.ossreviewtoolkit.utils.common.Os
 import org.ossreviewtoolkit.utils.common.ProcessCapture
 import org.ossreviewtoolkit.utils.test.ExpensiveTag

plugins/package-managers/sbt/src/funTest/kotlin/SbtFunTest.kt

@@ -23,8 +23,8 @@ import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.shouldBe
 
 import org.ossreviewtoolkit.analyzer.managers.analyze
-import org.ossreviewtoolkit.downloader.vcs.Git
 import org.ossreviewtoolkit.model.toYaml
+import org.ossreviewtoolkit.plugins.versioncontrolsystems.git.Git
 import org.ossreviewtoolkit.utils.test.getAssetFile
 import org.ossreviewtoolkit.utils.test.matchExpectedResult
 import org.ossreviewtoolkit.utils.test.patchActualResult

plugins/version-control-systems/build.gradle.kts

@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2023 The ORT Project Authors (see <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE>)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * License-Filename: LICENSE
+ */
+
+plugins {
+    // Apply precompiled plugins.
+    id("ort-plugins-conventions")
+}

plugins/version-control-systems/git/build.gradle.kts

@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2023 The ORT Project Authors (see <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE>)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * License-Filename: LICENSE
+ */
+
+plugins {
+    // Apply precompiled plugins.
+    id("ort-library-conventions")
+}
+
+dependencies {
+    api(project(":downloader"))
+    api(project(":model"))
+    api(project(":utils:common-utils")) {
+        because("This is a CommandLineTool.")
+    }
+
+    api(libs.semver4j) {
+        because("This is a CommandLineTool.")
+    }
+
+    implementation(project(":utils:ort-utils"))
+
+    implementation(libs.jgit)
+    implementation(libs.jgitSshApacheAgent) {
+        exclude(group = "org.apache.sshd", module = "sshd-sftp")
+            .because("it is not required for cloning via SSH and causes issues with GraalVM native images")
+    }
+
+    testImplementation(libs.mockk)
+}

downloader/src/funTest/kotlin/vcs/GitDownloadFunTest.kt → plugins/version-control-systems/git/src/funTest/kotlin/GitDownloadFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.core.spec.style.StringSpec

downloader/src/funTest/kotlin/vcs/GitFunTest.kt → plugins/version-control-systems/git/src/funTest/kotlin/GitFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import io.kotest.core.spec.style.WordSpec
 import io.kotest.engine.spec.tempdir

downloader/src/funTest/kotlin/vcs/GitRepoDownloadFunTest.kt → plugins/version-control-systems/git/src/funTest/kotlin/GitRepoDownloadFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import io.kotest.core.spec.Spec
 import io.kotest.core.spec.style.StringSpec

downloader/src/funTest/kotlin/vcs/GitWorkingTreeFunTest.kt → plugins/version-control-systems/git/src/funTest/kotlin/GitWorkingTreeFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.engine.spec.tempdir
@@ -86,7 +86,7 @@ class GitWorkingTreeFunTest : StringSpec({
             "plugins/package-managers/python/src/funTest/assets/projects/external/spdx-tools-python",
             "plugins/package-managers/sbt/src/funTest/assets/projects/external/sbt-multi-project-example",
             "plugins/package-managers/stack/src/funTest/assets/projects/external/quickcheck-state-machine"
-        ).associateWith { VersionControlSystem.getPathInfo(File("../$it")) }
+        ).associateWith { VersionControlSystem.getPathInfo(File("../../../$it")) }
 
         git.getWorkingTree(File("..")).getNested() shouldBe expectedSubmodules
     }

downloader/src/main/kotlin/vcs/Git.kt → plugins/version-control-systems/git/src/main/kotlin/Git.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import java.io.File
 import java.io.IOException

downloader/src/main/kotlin/vcs/GitRepo.kt → plugins/version-control-systems/git/src/main/kotlin/GitRepo.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty
 

downloader/src/main/kotlin/vcs/GitWorkingTree.kt → plugins/version-control-systems/git/src/main/kotlin/GitWorkingTree.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import java.io.File
 import java.io.IOException

plugins/version-control-systems/git/src/main/resources/META-INF/services/org.ossreviewtoolkit.downloader.VersionControlSystem

@@ -0,0 +1,2 @@
+org.ossreviewtoolkit.plugins.versioncontrolsystems.git.Git
+org.ossreviewtoolkit.plugins.versioncontrolsystems.git.GitRepo

downloader/src/test/kotlin/vcs/GitTest.kt → plugins/version-control-systems/git/src/test/kotlin/GitTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.git
 
 import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.core.spec.style.WordSpec

plugins/version-control-systems/mercurial/build.gradle.kts

@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2023 The ORT Project Authors (see <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE>)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * License-Filename: LICENSE
+ */
+
+plugins {
+    // Apply precompiled plugins.
+    id("ort-library-conventions")
+}
+
+dependencies {
+    api(project(":downloader"))
+    api(project(":model"))
+    api(project(":utils:common-utils")) {
+        because("This is a CommandLineTool.")
+    }
+
+    api(libs.semver4j) {
+        because("This is a CommandLineTool.")
+    }
+
+    implementation(project(":utils:ort-utils"))
+}

downloader/src/funTest/kotlin/vcs/MercurialDownloadFunTest.kt → plugins/version-control-systems/mercurial/src/funTest/kotlin/MercurialDownloadFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.mercurial
 
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.core.test.TestCase

downloader/src/funTest/kotlin/vcs/MercurialWorkingTreeFunTest.kt → plugins/version-control-systems/mercurial/src/funTest/kotlin/MercurialWorkingTreeFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.mercurial
 
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.engine.spec.tempdir

downloader/src/main/kotlin/vcs/Mercurial.kt → plugins/version-control-systems/mercurial/src/main/kotlin/Mercurial.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.mercurial
 
 import java.io.File
 

downloader/src/main/kotlin/vcs/MercurialWorkingTree.kt → plugins/version-control-systems/mercurial/src/main/kotlin/MercurialWorkingTree.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.mercurial
 
 import java.io.File
 

plugins/version-control-systems/mercurial/src/main/resources/META-INF/services/org.ossreviewtoolkit.downloader.VersionControlSystem

@@ -0,0 +1 @@
+org.ossreviewtoolkit.plugins.versioncontrolsystems.mercurial.Mercurial

plugins/version-control-systems/subversion/build.gradle.kts

@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2023 The ORT Project Authors (see <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE>)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * License-Filename: LICENSE
+ */
+
+plugins {
+    // Apply precompiled plugins.
+    id("ort-library-conventions")
+}
+
+dependencies {
+    api(project(":downloader"))
+    api(project(":model"))
+
+    implementation(project(":utils:common-utils"))
+    implementation(project(":utils:ort-utils"))
+
+    implementation(libs.svnkit) {
+        exclude(group = "org.apache.sshd", module = "sshd-core")
+            .because("it is included in JGit's sshd-osgi dependency")
+        exclude(group = "org.apache.sshd", module = "sshd-common")
+            .because("it is included in JGit's sshd-osgi dependency")
+    }
+}

downloader/src/funTest/kotlin/vcs/SubversionDownloadFunTest.kt → plugins/version-control-systems/subversion/src/funTest/kotlin/SubversionDownloadFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.subversion
 
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.core.test.TestCase

downloader/src/funTest/kotlin/vcs/SubversionWorkingTreeFunTest.kt → plugins/version-control-systems/subversion/src/funTest/kotlin/SubversionWorkingTreeFunTest.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.subversion
 
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.engine.spec.tempdir

downloader/src/main/kotlin/vcs/Subversion.kt → plugins/version-control-systems/subversion/src/main/kotlin/Subversion.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.downloader.vcs
+package org.ossreviewtoolkit.plugins.versioncontrolsystems.subversion
 
 import java.io.File
 import java.net.InetSocketAddress