Skip to content

Commit

Permalink
docs(go): Fix an obsolete code comment
Browse files Browse the repository at this point in the history
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
  • Loading branch information
fviernau committed Dec 13, 2023
1 parent 4aa865f commit 3d78d64
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions plugins/package-managers/go/src/main/kotlin/GoMod.kt
Original file line number Diff line number Diff line change
Expand Up @@ -436,14 +436,8 @@ private data class ModuleInfoFile(
}

private fun ModuleInfo.toSourceArtifact(): RemoteArtifact {
/**
* The below construction of the remote artifact URL makes several simplifying assumptions, and it is still
* questionable whether those assumptions are ok:
*
* 1. GOPROXY in general can hold a list of (fallback) proxy URLs.
* 2. There are special values like 'direct' and 'off'.
* 3. GOPRIVATE variable can specify glob expression against paths for which the proxy should be bypassed.
*/
// The below construction of the remote artifact URL simply assumes the module to be available at Go's default
// proxy, which might not always hold.
return RemoteArtifact(url = "$DEFAULT_GO_PROXY/$path/@v/$version.zip", hash = Hash.NONE)
}

Expand Down

0 comments on commit 3d78d64

Please sign in to comment.