Skip to content

Commit

Permalink
refactor(evaluated-model): Factor out some mapping to a function
Browse files Browse the repository at this point in the history
Prepare for applying further logic common to both code paths, without
adding code redundancy.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
  • Loading branch information
fviernau committed May 29, 2024
1 parent f6fa2cb commit 4342001
Showing 1 changed file with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,7 @@ internal class EvaluatedModelMapper(private val input: ReporterInput) {

issues += addAnalyzerIssues(project.id, evaluatedPackage)

input.ortResult.getScanResultsForId(project.id).mapTo(scanResults) { result ->
convertScanResult(result, findings, evaluatedPackage)
}
scanResults += convertScanResultsForPackage(evaluatedPackage, findings)

findings.filter { it.type == EvaluatedFindingType.LICENSE }.mapNotNullTo(detectedLicenses) { it.license }

Expand Down Expand Up @@ -342,9 +340,7 @@ internal class EvaluatedModelMapper(private val input: ReporterInput) {

issues += addAnalyzerIssues(pkg.id, evaluatedPackage)

input.ortResult.getScanResultsForId(pkg.id).mapTo(scanResults) { result ->
convertScanResult(result, findings, evaluatedPackage)
}
scanResults += convertScanResultsForPackage(evaluatedPackage, findings)

findings.filter { it.type == EvaluatedFindingType.LICENSE }.mapNotNullTo(detectedLicenses) { it.license }

Expand Down Expand Up @@ -410,6 +406,14 @@ internal class EvaluatedModelMapper(private val input: ReporterInput) {
)
}

private fun convertScanResultsForPackage(
pkg: EvaluatedPackage,
findings: MutableList<EvaluatedFinding>
): List<EvaluatedScanResult> =
input.ortResult.getScanResultsForId(pkg.id).map { scanResult ->
convertScanResult(scanResult, findings, pkg)
}

private fun convertScanResult(
result: ScanResult,
findings: MutableList<EvaluatedFinding>,
Expand Down

0 comments on commit 4342001

Please sign in to comment.