Scanner: How to upgrade scan-code version from ORT

[porsche-rishisaxena]

Scanner: We realized that ORT is running with year old version of scan-code. How to upgrade scan-code version from ORT to its latest version (scan-code)?

[tsteenbe]

@porsche-rishisaxena We will be soon upgrading to the latest version of ScanCode currently doing upgrade tests, but if you have locally or in your Docker image have newer version of ScanCode the ORT will use it.

[porsche-rishisaxena]

Thank you @tsteenbe for the providing an update. Would you be so kind to provide some more insight to scan-code version upgrade in context to timelines?

[tsteenbe]

@porsche-rishisaxena It's currently being worked on, expect at the latest last week of August if all goes well

[sschuberth]

@tsteenbe I'd be interested in what HERE is doing in the ScanCode upgrading context to maintain compatibility with existing scan results. That's a difficult topic, and one of the reasons why we didn't do the upgrade yet ourselves.

[porsche-rishisaxena]

@tsteenbe Would you be so kind to provide more information on what version of scan-code is under testing for the upgrade?

We ran multiple test with different version of Scan-Code and the latest version of scan-code also result with a bug.
Reference: #4295 (comment)

[sschuberth]

Would you be so kind to provide more information on what version of scan-code is under testing for the upgrade?

See the draft PR at #4324, it's version 21.7.30 (currently).

[porsche-rishisaxena]

@tsteenbe: Is there any update on the progress or result from testing on the scan-code upgrade?

[mnonnenmacher]

To give an update on this, I am currently working on some refactorings required to make the ScanCode version configurable. One blocker is currently that the ScanCode license texts included with ORT need to match the used ScanCode version. This will be fixed by #4523 and could later be improved by downloading license texts from https://scancode-licensedb.aboutcode.org/ or by aboutcode-org/scancode-toolkit#2738. This in turn depends on a refactoring of our utils modules which I have started in #4624 and which will require one more PR afterwards. Once this is done we can go ahead with #4582 and let users choose the ScanCode version they want to use, provided that there are no breaking changes in ScanCode's output format.

[porsche-rishisaxena]

Thank you so much @mnonnenmacher for making this issue progressive.
Is there any possibility to project any tentative timelines on the refactoring and making the scan-code version configurable to be upgraded?
Can we from Porsche AG side help in any way to move things forward in timely manner?

[mnonnenmacher]

@porsche-rishisaxena I cannot commit to a timeline as this is a side-task for me, but the largest part of the work is already done, so I hope this can be finished within the next two weeks.

[mnonnenmacher]

@porsche-rishisaxena With the merge of my latest PR (#4669) ORT does not require a specific ScanCode version anymore. We do not yet provide an easy way to build the Docker image with a different ScanCode version, but you could already fork this repository and replace the ScanCode version in the Dockerfile or create your own Dockerfile that inherits from ours.

[sschuberth]

We do not yet provide an easy way to build the Docker image with a different ScanCode version

This has been resolved meanwhile in #4721, and upgrading ScanCode is now as easy as setting the SCANCODE_VERSION build argument when running docker build.