Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic about using custom / newer ScanCode versions #4631

Closed
11 tasks done
sschuberth opened this issue Oct 28, 2021 · 4 comments
Closed
11 tasks done

Epic about using custom / newer ScanCode versions #4631

sschuberth opened this issue Oct 28, 2021 · 4 comments
Labels
enhancement Issues that are considered to be enhancements epic A "parent" issue that refers to multiple other issues scanner About the scanner tool

Comments

@sschuberth
Copy link
Member

sschuberth commented Oct 28, 2021

Currently, the ScanCode version to use is hard-coded in ORT. This tight coupling prevents mixing of arbitrary ORT / ScanCode versions, and hinders a fast / user-specific upgrade of ScanCode (also see #4296).

To solve this, the following things would need to be addressed:

FAQ

Why not just always use the latest version of ScanCode in ORT?

  • Different findings might render existing package configurations invalid.
  • Expensive testing might be required.
@sschuberth sschuberth added enhancement Issues that are considered to be enhancements epic A "parent" issue that refers to multiple other issues scanner About the scanner tool labels Oct 28, 2021
@sschuberth sschuberth changed the title Epic about making the ScanCode version configurable (WIP) Epic about making the ScanCode version configurable Oct 28, 2021
@sschuberth sschuberth changed the title Epic about making the ScanCode version configurable Epic about using custom / newer ScanCode versions Nov 4, 2021
@sschuberth sschuberth pinned this issue Nov 12, 2021
@maxhbr
Copy link
Contributor

maxhbr commented Dec 8, 2021

#1580 is closed. Does that mean that all boxes in "Improve the boostrapping of scanners" can be checked?

@sschuberth
Copy link
Member Author

sschuberth commented Dec 8, 2021

Yes, thanks for the reminder, done.

@mnonnenmacher
Copy link
Member

@sschuberth Don't you think we can close this epic as the two open tickets are not required for choosing a custom ScanCode version?

@sschuberth
Copy link
Member Author

Agreed. #3247 is anyway n/a anymore by now, and #3223 should not block / be part of this epic.

@sschuberth sschuberth unpinned this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements epic A "parent" issue that refers to multiple other issues scanner About the scanner tool
Projects
None yet
Development

No branches or pull requests

3 participants