Start splitting :utils:core #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
force-pushed
the
split-utils-core
branch
2 times, most recently
from
9600ce5
to
4fd2696
Compare
sschuberth
requested changes
Nov 2, 2021
The module will be used for helper functions that are not specific to ORT, so that other utility modules like the clients or the SPDX utils can depend on it. These will be moved to the new module in later commits. To automatically include the new module in all ORT modules, add it as an API dependency to `:utils:core`, similary to how `:model` includes `:utils:core` as an API dependency. Also add the new package to the default imports of all `ScriptRunner`s to ensure that user scripts keep working. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
`ArchiveUtils` is a better place for the function as it contains related helper functions. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
Extension functions should be placed in `Extensions.kt`. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
The code is not specific to ORT and can be useful for other modules. Drop the single log statement because the log helper is not available in the common module and the (potentially fixed) user home property is implicitly dumped as part of `ORT_DATA_DIR`. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
The code is not specific to ORT and can be useful for other modules. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
force-pushed
the
split-utils-core
branch
from
4fd2696
to
fa375ef
Compare
sschuberth
approved these changes
Nov 2, 2021
mnonnenmacher
added
the
breaking change
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to split
:utils:coreinto two separate modules by creating the:utils:commonmodule and moving the first code there. This will be finished in another PR. Please see the commit messages for details.