Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-App Scan Results: Increase Pagination Option or Copy-All-Button Feature #6980

Closed
LukasWohlfart opened this issue May 9, 2023 · 5 comments · Fixed by #7144
Closed

Web-App Scan Results: Increase Pagination Option or Copy-All-Button Feature #6980

LukasWohlfart opened this issue May 9, 2023 · 5 comments · Fixed by #7144
Assignees
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool

Comments

@LukasWohlfart
Copy link

Regarding the Pagination Size Options in the Web-App Report I suggest to either:

  1. add a fifth pageSizeOption significantly larger than the current maximum of 500. e.g. 5000
    or
  2. add a Copy-All-Button Feature

Reasoning: Working with the Scan Results from the Web-App in another tool may require to copy the whole Scan Results [Use-case e.g. to filter on the path]. In many projects the Scan Results have way more than 500 detections making it necessary to copy paste multiple times by flipping through the pages.

@sschuberth
Copy link
Member

Working with the Scan Results from the Web-App in another tool may require to copy the whole Scan Results

That sounds like the wrong way to achieve what you want. Depending on what that other tool is, it might more sense to write a custom reporter plugin for your use-case.

@sschuberth sschuberth added enhancement Issues that are considered to be enhancements reporter About the reporter tool labels May 9, 2023
@tsteenbe
Copy link
Member

@LukasWohlfart The 500 limit was chosen not to overload the web browser - ORT is used by organizations that employ license clearance teams in India who don't use the latest and greatest hardware. Recommend you like Sebastian said a customer reporter via AsciiDoc Template or PlainTextTemplate - You can even use these to generate an Excel of all the findings. If you don't have the skills in-house within your employer then I am happy to connect you with one of the several commercial ORT support providers

@tsteenbe tsteenbe self-assigned this May 10, 2023
@sschuberth
Copy link
Member

This issue was brought up in the ORT Community Meeting by @porsche-rbieniek again. It seems our replies were somehow perceived as harsh, which clearly was not our intention. @LukasWohlfart, would your use-case be solved by a reporter-specific option that allows to customize the pagination limit (but still defaults to 500)?

@LukasWohlfart
Copy link
Author

LukasWohlfart commented Jun 15, 2023

@sschuberth yes the option to set a custom pagination limit would be a feasible trade-off.
Defaulting to 500 is not an issue.

sschuberth added a commit that referenced this issue Jun 16, 2023
While these page sizes usually are too large for browsers to handle,
there seem to be use-cases where trying it out makes sense. So let users
chose these at their own risk.

Resolves #6980.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
Copy link
Member

I've changed my mind an decided to add 1000 and 5000 page size option unconditionally. Use at your own risk 😉, see #7144.

sschuberth added a commit that referenced this issue Jun 16, 2023
While these page sizes usually are too large for browsers to handle,
there seem to be use-cases where trying it out makes sense. So let users
chose these at their own risk.

Resolves #6980.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants