Safe copy recursively #1235
Merged
Safe copy recursively #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of a52a984 we use File.delete() which really deletes the junction instead of unlinking it and turning it into an empty directory. In any case the contents of the link target are not deleted. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
|
@msohn, mind trying this branch? |
Because Kotlin's File.copyRecursively() might run into an endless loop for links that point to the parent directory, see https://youtrack.jetbrains.com/issue/KT-29508 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
force-pushed
the
safe-copy-recursively
branch
from
4770d38
to
89c3d54
Compare
safeCopyRecursively() can handle links whose target is the parent directory like at https://github.com/gardener/gardener/tree/ee3872ddde8fdc768e33bce9efd2638aefc36cce/vendor/github.com/coreos/etcd/cmd This fixes one part of issue #1233. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
force-pushed
the
safe-copy-recursively
branch
from
89c3d54
to
7028465
Compare
mnonnenmacher
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
This change is