-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to pass report-format-specific options #2635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @bs-ondem |
sschuberth
force-pushed
the
report-format-options
branch
from
May 19, 2020 14:22
0f57df6
to
c5276c7
Compare
mnonnenmacher
requested changes
May 25, 2020
fviernau
previously requested changes
May 25, 2020
And also perform some minor related renamings / alignments between AnalyzerCommand and ReporterCommand. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
report-format-options
branch
from
May 25, 2020 12:13
c5276c7
to
b8a33a0
Compare
This will become useful once a report format takes options, e.g. for custom styling. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
report-format-options
branch
from
May 25, 2020 12:23
b8a33a0
to
48ff4fa
Compare
mnonnenmacher
approved these changes
May 25, 2020
Merging this despite the unrelated Travis failure as AppVeyor passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will become useful once a report format takes options, e.g. for
custom styling.
Signed-off-by: Sebastian Schuberth sebastian.schuberth@bosch.io