GoMod: Support all hosts known to VcsHost #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
fviernau
requested changes
Jun 4, 2021
sschuberth
force-pushed
the
gomod-vcs-vs-proxy
branch
from
58fda9e
to
fc6adf3
Compare
Previously, VcsHost was only used for "github.com". Make use of the host detection in VcsHost instead to support more hosts. This way the fallback to proxy artifacts, for which we have only limited support according to the code comments, might be triggered less often. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
gomod-vcs-vs-proxy
branch
from
fc6adf3
to
1e11582
Compare
fviernau
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, VcsHost was only used for "github.com". Make use of the host
detection in VcsHost instead to support more hosts.
This way the fallback to proxy artifacts, for which we have only limited
support according to the code comments, might be triggered less often.
Signed-off-by: Sebastian Schuberth sebastian.schuberth@bosch.io