-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show vulnerabilities WebApp report #4736
Conversation
reporter/src/funTest/assets/evaluated-model-reporter-test-expected-output.json
Show resolved
Hide resolved
Could we maybe get a screenshot of how this looks like in the current state? |
There is one on Slack: https://ort-talk.slack.com/archives/C9NNJ54B1/p1637677784105200?thread_ts=1637668788.095300&cid=C9NNJ54B1 |
Right, but that before adding the severities, or? |
They are encoded in the icons, see: https://ort-talk.slack.com/archives/C9NNJ54B1/p1638215346139200?thread_ts=1638180931.138600&cid=C9NNJ54B1 |
Ah, somehow that thread didn't update for me in Slack, and I didn't see @tsteenbe's response. Thanks for pointing this out! |
@tsteenbe could you please rebase once more? |
47df69d
to
b5a5efd
Compare
Use the same indexing method used in both issues and rule violations where for some values array indexes are used to refer to entries elsewhere in the model. Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Add EvaluatedVulnerabilityReference in order to get the severity as a string e.g. 'Critical', 'High', 'Low', etc. Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Align file with default property values setting in other WebApp model files. Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
Closes #4630. Signed-off-by: Thomas Steenbergen <thomas.steenbergen@here.com>
This hopefully gets rid of this bogus build error: > Task :reporter-web-app:yarnBuild FAILED yarn run v1.22.10 $ rescripts build info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. node:internal/modules/cjs/loader:936 throw err; ^ Error: Cannot find module '../scripts/build' Require stack: - /home/vsts/work/1/s/reporter-web-app/node_modules/.bin/rescripts at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15) at Function.resolve (node:internal/modules/cjs/helpers:108:19) at Object.<anonymous> (/home/vsts/work/1/s/reporter-web-app/node_modules/.bin/rescripts:35:25) at Module._compile (node:internal/modules/cjs/loader:1101:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) at node:internal/main/run_main_module:17:47 { code: 'MODULE_NOT_FOUND', requireStack: [ '/home/vsts/work/1/s/reporter-web-app/node_modules/.bin/rescripts' ] } error Command failed with exit code 1. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
b5a5efd
to
1202e9f
Compare
Ignoring the unrelated failing tests. |
Initial implementation to show vulnerabilities in the WebApp report.
Closes #4630