Sanitize creating an Identifier from SPDX
#4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
…X name There is no strict need to deduplicate the SPDX name like this as only the SPDX ID needs to be unique. Also, the type and namespace can be retrieved from the PURL. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
id-spdx-sanitize
branch
from
2a0c6df
to
46c4b9d
Compare
|
Adding |
MarcelBochtler
added
the
breaking change
| * supported, replace them with dashes, too, for readability. | ||
| */ | ||
| private fun String.sanitize(): String = | ||
| replace(Regex("[: ]"), "-").replace(Regex("-{2,}"), "-") |
There was a problem hiding this comment.
While I agree that replacing spaces with dashes is a good idea, it will break a lot of curations and I'm not sure if readability is worth it.
There was a problem hiding this comment.
I don't believe there are many SpdxDocumentFile-type curations for packages with spaces in their names around, but I agree we should be conservative still, and I've changed the implementation.
Together with the previous commit, this fixes #4744. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
id-spdx-sanitize
branch
from
46c4b9d
to
0c043ce
Compare
|
@oss-review-toolkit/core-devs can we move forward with this? |
mnonnenmacher
approved these changes
Dec 3, 2021
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.