Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectSourceRule: Add a matcher for the project's VCS type #5823

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Sep 19, 2022

See individual commits.

Part of #5621.

@fviernau fviernau requested a review from a team as a code owner September 19, 2022 11:03
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #5823 (c9ef373) into main (425ac7c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5823      +/-   ##
============================================
+ Coverage     57.70%   57.71%   +0.01%     
  Complexity     2192     2192              
============================================
  Files           321      321              
  Lines         18989    18989              
  Branches       3730     3730              
============================================
+ Hits          10957    10959       +2     
+ Misses         6891     6889       -2     
  Partials       1141     1141              
Flag Coverage Δ
funTest-analyzer-docker 74.54% <ø> (ø)
funTest-non-analyzer 46.21% <ø> (ø)
test 27.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../curation/ClearlyDefinedPackageCurationProvider.kt 48.80% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tsteenbe tsteenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit "The matcher can be used to enable rule only for certain VCS types." change to "The matcher can be used to enable a rule only for certain VCS types."

@fviernau fviernau force-pushed the project-source-rule-vcs-type-matcher branch from b281c16 to 74d5458 Compare September 19, 2022 11:24
Prepare for re-use in a following change.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The matcher can be used to enable a rule only for certain VCS types.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@tsteenbe tsteenbe merged commit 23c4ae8 into main Sep 19, 2022
@tsteenbe tsteenbe deleted the project-source-rule-vcs-type-matcher branch September 19, 2022 13:07
@sschuberth sschuberth added the release notes Changes that should be mentioned in release notes label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Changes that should be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants