model: Move ScanResultContainer to FileBasedStorage
#5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class does not have any custom (de-)serializer, so testing (de-)serialization is not necessary. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Implementing that interface is not needed and `compareTo` is currently unused. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The only use of `ScanResultContainer` is within `FileBasedStorage`. So, hide it there as an implementation detail. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Codecov ReportBase: 58.42% // Head: 58.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
============================================
+ Coverage 58.42% 58.52% +0.09%
Complexity 2090 2090
============================================
Files 321 321
Lines 18684 18672 -12
Branches 3779 3775 -4
============================================
+ Hits 10916 10927 +11
+ Misses 6686 6662 -24
- Partials 1082 1083 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mnonnenmacher
approved these changes
Oct 11, 2022
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
ScanResultContainerto the only place where it's being used.Part of #5681.