Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzer: Use the HTTPS instead of the Git protocol in VCS processed #5948

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Oct 13, 2022

See individual commits.

Note: This moves forwards scanning ORT with ORT, e.g. #5696.

Make it simpler and allow for finding the usage of the asset via a
simple `grep`.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 57.93% // Head: 57.95% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c71ed0a) compared to base (d7d5b83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5948      +/-   ##
============================================
+ Coverage     57.93%   57.95%   +0.01%     
  Complexity     2057     2057              
============================================
  Files           322      322              
  Lines         18666    18666              
  Branches       3759     3759              
============================================
+ Hits          10815    10817       +2     
+ Misses         6804     6802       -2     
  Partials       1047     1047              
Flag Coverage Δ
funTest-analyzer-docker 74.87% <ø> (ø)
funTest-non-analyzer 50.42% <ø> (ø)
test 27.60% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../curation/ClearlyDefinedPackageCurationProvider.kt 48.80% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fviernau fviernau marked this pull request as ready for review October 13, 2022 11:07
@fviernau fviernau requested a review from a team as a code owner October 13, 2022 11:07
@sschuberth
Copy link
Member

Note: This moves forwards scanning ORT with ORT.

BTW, we have an issue for this that you may want to refer to: #5696 (Although that also includes setting up the automation to do this regularly.)

The Git protocol is blocked by many VCS hosts nowadays and leads to
timeout errors when ORT attempts downloading or scanning. So, avoid
these unnecessary and slow timeouts by using the HTTPS protocol
instead.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau force-pushed the analyzer-use-https-instead-of-git-protocol branch from bd5fdf6 to c71ed0a Compare October 13, 2022 11:27
@fviernau fviernau enabled auto-merge (rebase) October 13, 2022 11:28
@fviernau fviernau merged commit 4c57907 into main Oct 13, 2022
@fviernau fviernau deleted the analyzer-use-https-instead-of-git-protocol branch October 13, 2022 13:10
@sschuberth sschuberth added the release notes Changes that should be mentioned in release notes label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Changes that should be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants