Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject dependencies on the ORT configuration via Koin #6037

Closed
wants to merge 1 commit into from

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 57.79% // Head: 58.03% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (631056a) compared to base (5788347).
Patch coverage: 57.89% of modified lines in pull request are covered.

❗ Current head 631056a differs from pull request most recent head cfe28dc. Consider uploading reports for the commit cfe28dc to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6037      +/-   ##
============================================
+ Coverage     57.79%   58.03%   +0.24%     
  Complexity     2013     2013              
============================================
  Files           324      324              
  Lines         18761    18699      -62     
  Branches       3876     3847      -29     
============================================
+ Hits          10842    10852      +10     
+ Misses         6862     6786      -76     
- Partials       1057     1061       +4     
Flag Coverage Δ
funTest-analyzer-docker 74.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/kotlin/config/FileArchiverConfiguration.kt 38.09% <0.00%> (ø)
model/src/main/kotlin/utils/OrtResultExtensions.kt 0.00% <0.00%> (ø)
cli/src/main/kotlin/commands/ReporterCommand.kt 55.68% <20.00%> (ø)
cli/src/main/kotlin/commands/EvaluatorCommand.kt 52.84% <44.44%> (ø)
...n/kotlin/commands/UploadResultToPostgresCommand.kt 40.00% <50.00%> (ø)
...main/kotlin/commands/UploadResultToSw360Command.kt 19.35% <50.00%> (ø)
cli/src/main/kotlin/commands/DownloaderCommand.kt 36.02% <57.14%> (ø)
cli/src/main/kotlin/commands/ScannerCommand.kt 51.72% <75.00%> (ø)
cli/src/main/kotlin/commands/AdvisorCommand.kt 63.23% <80.00%> (ø)
cli/src/main/kotlin/commands/ConfigCommand.kt 56.25% <83.33%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sschuberth
Copy link
Member Author

I do not plan to pursue this idea further currently.

@sschuberth sschuberth closed this Oct 9, 2023
@sschuberth sschuberth deleted the koin-inject-config branch October 9, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant