Set the code point limit for SnakeYAML to 1GB #6124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 1.32 [1] SnakeYAML sets the limit for incoming data to 3MB. Since Jackson 2.14 [2] it is possible to override this default, so hardcode the limit to 1GB to allow parsing large ORT result files. [1]: https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes [2]: FasterXML/jackson-dataformats-text#337 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
|
Should this auto-close #5818? |
|
Also, should we add a test that writes a 4 MiB dummy YAML file? |
|
Let's address my remarks manually / separately and merge this to fixup #6123 for the changes. |
sschuberth
approved these changes
Nov 28, 2022
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1.32 1 SnakeYAML sets the limit for incoming data to 3MB. Since Jackson 2.14 2 it is possible to override this default, so hardcode the limit to 1GB to allow parsing large ORT result files.