analyzer: Stop using a SortedSet in ProjectAnalyzerResult

[sschuberth]

The ProjectAnalyzerResult is only serialized as part of analyzer functional tests when comparing to expected results. So in memory, there is no need for the packages to be a SortedSet. Change the code to only sort packages on serialization via a Jackson converter to have a defined order when comparing to expected results.

Signed-off-by: Sebastian Schuberth sschuberth@gmail.com

Part of: #6235

[sschuberth]

For now, this is a generic implementation that works on Comparable<T>, which has the downside that the classes still need to implement Comparable, and the current implementations are confusing as they're not in line with equals().

So maybe we should prefer to have dedicated converters per class that we want to sort as these could hard-code the property to sort on then, like

class SortedPackageSetConverter : StdConverter<Set<Package>, Set<Package>>() {
    override fun convert(value: Set<Package>): Set<Package> =
        value.toSortedSet(compareBy { it.id })
}

That would allow us to remove the Comparable implementations in exchange for several more converted classes. But as there are only ~10 implementations that we need to care about as they influence serialization, that's maybe still a good idea.

[sschuberth]

So maybe we should prefer to have dedicated converters per class [...] That would allow us to remove the Comparable implementations in exchange for several more converted classes.

For the record, that's what I did now.

[sschuberth]

FYI @mnonnenmacher, a SortedSet keeps only the first entry that's equal according to compareTo, see https://pl.kotl.in/zzR5V7Npo.

Which means that this change may uncover previously unnoticed cases where packages with the same id but different other properties are being added to the result.