Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the curation provider API to take packages instead of ids #6387

Merged
merged 1 commit into from
Feb 8, 2023

Commits on Feb 8, 2023

  1. refactor(PackageCurationProvider)!: Query packages instead of ids

    Strictly speaking, a package id is not enough to query curations as
    different servers might host different artifacts under the same id. A
    typical example is an internal fork of an upstream artifact that is
    internally hosted under the same id.
    
    Currently, ClearlyDefined is the only curation provider that allows to
    take this into account via its "provider" concept, see [1] and [2] for
    related discussions. So, as a preparation for ORT to replace the
    hard-coded providers [3] with real ones determined based on URLs, change
    the curation provider API to take whole packages instead of only their
    ids, so that implementations have access to artifacts and VCS URLs.
    
    [1]: #155
    [2]: package-url/purl-spec#33
    [3]: https://github.com/oss-review-toolkit/ort/blob/33531c7/model/src/main/kotlin/utils/Extensions.kt#L38-L57
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
    sschuberth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    033be89 View commit details
    Browse the repository at this point in the history