Move the Unmanaged package manager to its own plugin project #6797
Conversation
This is a preparation for moving the `Unmanaged` package manager to its own plugin project. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #6797 +/- ##
=========================================
Coverage 64.62% 64.62%
Complexity 1955 1955
=========================================
Files 322 322
Lines 16166 16166
Branches 2296 2296
=========================================
Hits 10448 10448
Misses 4726 4726
Partials 992 992
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -109,7 +108,8 @@ class Analyzer(private val config: AnalyzerConfiguration, private val labels: Ma | |||
| } | |||
|
|
|||
| if (!hasOnlyManagedDirs) { | |||
| distinctPackageManagers.find { it is Unmanaged.Factory } | |||
| val unmanagedPackageManagerFactory = PackageManager.ALL["Unmanaged"] | |||
There was a problem hiding this comment.
Oh, I recall that the way we associate scan results with definition files / projects relies on the assumption that the Unmanaged package manager is present. If that doesn't hold, then detected licenses may get discarded silently.
This can be considered out of scope here, but should we do something about it?
(A first idea would be to disallow disabling it)
There was a problem hiding this comment.
Oh, I recall that the way we associate scan results with definition files / projects relies on the assumption that the
Unmanagedpackage manager is present.
Good point. That somewhat relates to #5365 (comment).
A first idea would be to disallow disabling it
I think that's a good idea. We should probably ensure that
- it's always present on the classpath,
- it must not be explicitly disabled,
- it must not be implicitly disabled by only enabling other package managers.
I'll probably make a follow-up PR.
Please have a look at the individual commit messages for the details.