Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scanner)!: Use the configurable plugin API for scanner wrappers #7673

Merged
merged 1 commit into from
Oct 11, 2023

Commits on Oct 11, 2023

  1. refactor(scanner)!: Use the configurable plugin API for scanner wrappers

    Use the `TypedConfigurablePluginFactory` interface as base for the
    `ScannerWrapperFactory` to further align the plugin APIs. While at it,
    extract the logic to parse the scanner matcher properties to a central
    place to not have to repeat the properties in the configuration classes
    for all scanner wrappers. This also makes it possible to use `Unit` as
    configuration class for scanners that do not offer any configuration
    options.
    
    As this change makes the configuration classes of the scanner wrappers
    part of the public API, they must not be `internal` anymore.
    
    Scanners that provide secret configuration options will be migrated to
    read them from the `secrets` map instead of the `options` map in later
    commits.
    
    Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
    mnonnenmacher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9577b50 View commit details
    Browse the repository at this point in the history