Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): Rename images to new defaults #7801

Merged
merged 5 commits into from
Nov 9, 2023
Merged

feat(docker): Rename images to new defaults #7801

merged 5 commits into from
Nov 9, 2023

Commits on Nov 9, 2023

  1. fix(docker): Stop accidentally skipping component image builds 

    In order to assemble the ORT docker image(s), the GitHub action first
builds the component images and then the main images using the
previously built component images.
Each component image build is skipped (for efficiency) if the image
with the needed tag already exists.

As tag, the version of the tooling of the particular ecosystem is used,
e.g. ghcr.io/oss-review-toolkit/python:3.11.5.

Using only the main tooling version as cache key is problematic, because
it leads to accidentally skipping of component image builds.
This may happen when any of the BUILD ARGS has changed.

Fix this by including a hash of the build args into the image tags.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
    @heliocastro @tsteenbe
    heliocastro authored and tsteenbe committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b7ba6ea View commit details
    Browse the repository at this point in the history

  2. feat(docker): Change naming default and unify docker files 

    The name changing allows to move the extended separated bits on previous
adoption to a unified file.
Now the new run target is based on previous extended image, and the
original run target is now called minimal.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
    @heliocastro @tsteenbe
    heliocastro authored and tsteenbe committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b6a5cfa View commit details
    Browse the repository at this point in the history

  3. fix(docker): Match docker scripts to upstream image naming 

    Change the build scripts to new minimal / ort images.
Naming had a slightly change from components as add to a subdomain
(ort/component) to a direct component naming, making equal to upstream
naming.

The explicit call to Dockerfile file name is not needed anymore, as
only a single Dockerfile exists after name changing.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
    @heliocastro @tsteenbe
    heliocastro authored and tsteenbe committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c768c37 View commit details
    Browse the repository at this point in the history

  4. chore(docker): Rename output of custom Dockerfile 

    Custom image now is named with dash to match Dockerfile-legacy
naming.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
    @heliocastro @tsteenbe
    heliocastro authored and tsteenbe committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9d7ec01 View commit details
    Browse the repository at this point in the history

  5. feat(docker): Rename images to agreed names 

    Rename Docker image 'ort' to 'ort-minimal' and  'ort-extended' to 'ort'
as agreed in community vote to make it easier for new users to understand
difference between ORT Docker images.

Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
    @heliocastro @tsteenbe
    heliocastro authored and tsteenbe committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    54fe55f View commit details
    Browse the repository at this point in the history