-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor StaticHTML reporter code improvements #7916
Conversation
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The code block is so large that it is hard to read. Reduce the nesting to make reading a tad easier, and to prepare for splitting up this large code block in upcoming changes. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, is the static HTML reporter still be using (on your side)? I'm every now and then tempted to remove it.
I'm still using it. I'll now incrementally make the mapper code more readable, as it is too hard for me to change it in the current state. Once done, I plan to do some improvements to the StaticHtml report. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7916 +/- ##
=========================================
Coverage 66.96% 66.96%
Complexity 2041 2041
=========================================
Files 356 356
Lines 17084 17084
Branches 2443 2443
=========================================
Hits 11440 11440
Misses 4623 4623
Partials 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Generally, I'd be interested for what features you're still using it, and whether it makes more sense to migrate any missing feature to the web app reporter instead of adding more feature to the static HTML reporter. Maybe a good topic for the community meeting to get a feeling for which reasons, if at all, people are still using the static report. |
I'd need to prepare for that, as I would need to actually do some clearance work and take notes of the things. |
See individual commits.