Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor StaticHTML reporter code improvements #7916

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

fviernau
Copy link
Member

See individual commits.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The code block is so large that it is hard to read. Reduce the nesting
to make reading a tad easier, and to prepare for splitting up this
large code block in upcoming changes.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau requested a review from a team as a code owner November 22, 2023 08:50
Copy link
Member

@sschuberth sschuberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, is the static HTML reporter still be using (on your side)? I'm every now and then tempted to remove it.

@fviernau
Copy link
Member Author

fviernau commented Nov 22, 2023

ust wondering, is the static HTML reporter still be using (on your side)? I'm every now and then tempted to remove it.

I'm still using it. I'll now incrementally make the mapper code more readable, as it is too hard for me to change it in the current state. Once done, I plan to do some improvements to the StaticHtml report.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e4a20c) 66.96% compared to head (b6bf04f) 66.96%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7916   +/-   ##
=========================================
  Coverage     66.96%   66.96%           
  Complexity     2041     2041           
=========================================
  Files           356      356           
  Lines         17084    17084           
  Branches       2443     2443           
=========================================
  Hits          11440    11440           
  Misses         4623     4623           
  Partials       1021     1021           
Flag Coverage Δ
funTest-docker 66.91% <ø> (ø)
funTest-non-docker 34.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth
Copy link
Member

sschuberth commented Nov 22, 2023

Once done, I plan to do some improvements to the StaticHtml report.

Generally, I'd be interested for what features you're still using it, and whether it makes more sense to migrate any missing feature to the web app reporter instead of adding more feature to the static HTML reporter. Maybe a good topic for the community meeting to get a feeling for which reasons, if at all, people are still using the static report.

@fviernau
Copy link
Member Author

fviernau commented Nov 22, 2023

Generally, I'd be interested for what features you're still using it, and whether it makes more sense to migrate any missing feature to the web app reporter instead of adding more feature to the static HTML reporter. Maybe a good topic for the community meeting to get a feeling for which reasons, if at all, people are still using the static report.

I'd need to prepare for that, as I would need to actually do some clearance work and take notes of the things.
I can't promise to have time for that very soon-ish. Out of my head, searching, copy-pasting and deep-links I believe are better in the static HTML. Also re-generating it should be faster. Finding things I look for can be done without any clicking, expanding using the mouse.

@fviernau fviernau merged commit caedab1 into main Nov 22, 2023
22 checks passed
@fviernau fviernau deleted the minor-reporter-improvements branch November 22, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants