analyzer: Update expected results for spdx-tools-python in PipTest
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency on "pyparsing" was updated from 2.2.0 to 2.2.1.
|
How/when did this change? Did we deliberately change the revision that the git submodule for spdx-tools-python points to? edit: Nevermind. I just looked at the spdx-tools-python repo and saw that it lists dependencies without versions. In this case I don't think it is useful to include the versions of installed dependencies in our test assertions. I realized that this is a side-effect of using fixtures the way we currently do, so fixing this is a bigger task and out of scope for this PR. |
haikoschol
approved these changes
Sep 18, 2018
|
@haikoschol exactly, in addition we have no control over versions of transitive dependencies because there is no such thing as a lock file in PIP. Related to: #755 |
sschuberth
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on "pyparsing" was updated from 2.2.0 to 2.2.1.
This change is