fix(spdx-utils): Support dashed reference category names #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oheger-bosch
previously approved these changes
Sep 17, 2024
sschuberth
force-pushed
the
spdx-2.2.0-vs-2.2.2
branch
from
abcb246
to
d508a0a
Compare
| import org.ossreviewtoolkit.utils.spdx.SpdxModelMapper | ||
|
|
||
| class SpdxExternalReferenceTest : WordSpec({ | ||
| "Serializing a categories" should { |
There was a problem hiding this comment.
Nit: "Serializing categories" or "Serializing a category". Same for deserializing below.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9157 +/- ##
=========================================
Coverage 67.08% 67.08%
Complexity 1188 1188
=========================================
Files 240 240
Lines 7901 7901
Branches 915 915
=========================================
Hits 5300 5300
Misses 2232 2232
Partials 369 369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
spdx-2.2.0-vs-2.2.2
branch
from
d508a0a
to
6b7c454
Compare
oheger-bosch
previously approved these changes
Sep 17, 2024
sschuberth
force-pushed
the
spdx-2.2.0-vs-2.2.2
branch
from
6b7c454
to
8e5fccd
Compare
|
Sorry @oheger-bosch, I had to fix this up yet again to not require changes in ORT's test assets and run into the same discussion about backward compatibility as for #7839. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This is a follow-up to the unmerged changes from [1] to support reading dashed reference category names while still writing underscored names for backward compatibility with ORT's code base. [1]: https://github.com/oss-review-toolkit/ort/pull/7839/files#diff-d290822c4f4714ad4b5d29e52d75edfa3c70e3e80e258d69adf0f6a82d8ae9a4 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
spdx-2.2.0-vs-2.2.2
branch
from
8e5fccd
to
4d6e07c
Compare
oheger-bosch
approved these changes
Sep 17, 2024
|
Merging despite the unrelated Python test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives the change from 1 for compatibility when reading SPDX files.