Review fixes

ostis-ai · Jun 19, 2024 · 4280a36 · 4280a36
1 parent 1611fed
commit 4280a36
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/manager/agents/init-module/utils/sc_component_manager_command_init.cpp b/src/manager/agents/init-module/utils/sc_component_manager_command_init.cpp
@@ -23,9 +23,7 @@ ScAddrUnorderedSet ScComponentManagerCommandInit::Execute(ScMemoryContext * cont
   while (repositoriesIterator->Next())
   {
     repository = repositoriesIterator->Get(2);
-    ScAddrUnorderedSet specificationsTemp = ProcessRepository(context, repository);
-
-    specifications.insert(specificationsTemp.cbegin(), specificationsTemp.cend());
+    ProcessRepository(context, repository, specifications);
   }
 
   return specifications;
@@ -36,17 +34,16 @@ ScAddrUnorderedSet ScComponentManagerCommandInit::Execute(ScMemoryContext * cont
  * @param context current sc-memory context
  * @param repository ScAddr of a repository of components to load
  */
-ScAddrUnorderedSet ScComponentManagerCommandInit::ProcessRepository(ScMemoryContext * context, ScAddr & repository)
+void ScComponentManagerCommandInit::ProcessRepository(ScMemoryContext * context, ScAddr & repository, ScAddrUnorderedSet & specifications)
 {
-  ScAddrUnorderedSet specifications;
   ScAddr const & specificationsSetAddr = utils::IteratorUtils::getAnyByOutRelation(
       context, repository, keynodes::ScComponentManagerKeynodes::rrel_components_specifications);
   if (!context->IsElement(specificationsSetAddr))
   {
     SC_LOG_WARNING(
         "ScComponentManagerCommandInit: components specification not found in repository "
         << context->HelperGetSystemIdtf(repository));
-    return specifications;
+    return;
   }
 
   ScAddr componentSpecification;
@@ -72,6 +69,4 @@ ScAddrUnorderedSet ScComponentManagerCommandInit::ProcessRepository(ScMemoryCont
     SC_LOG_DEBUG(
         "ScComponentManagerCommandInit: loaded specification " << context->HelperGetSystemIdtf(componentSpecification));
   }
-
-  return specifications;
 }
diff --git a/src/manager/agents/init-module/utils/sc_component_manager_command_init.hpp b/src/manager/agents/init-module/utils/sc_component_manager_command_init.hpp
@@ -23,7 +23,7 @@ class ScComponentManagerCommandInit : public ScComponentManagerCommand
 
   ScAddrUnorderedSet Execute(ScMemoryContext * context, ScAddr const & actionAddr) override;
 
-  ScAddrUnorderedSet ProcessRepository(ScMemoryContext * context, ScAddr & repositories);
+  void ProcessRepository(ScMemoryContext * context, ScAddr & repositories, ScAddrUnorderedSet & specifications);
 
 protected:
   std::string m_specificationsPath;