Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove codegen #117

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kilativ-dotcom
Copy link
Member

@kilativ-dotcom kilativ-dotcom commented Sep 12, 2024

  • Update changelog if needed
  • Update SCn documentation if needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно файл убрать

@@ -83,7 +83,7 @@ class DownloaderGit : public Downloader
{
if (!sc_fs_create_directory(downloadPath.c_str()))
{
SC_LOG_ERROR("Can't download. Can't create folder. " << downloadPath);
SC_LOG_ERROR("Can't download repository. Can't create folder. " << downloadPath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SC_LOG_ERROR("Can't download repository. Can't create folder. " << downloadPath);
SC_AGENT_LOG_ERROR("Can't download repository. Can't create folder. " << downloadPath);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

эту ерунду можно только в агентах использовать, я могу добавить DownloaderGit к сообщению

@@ -44,7 +41,7 @@ ScAddrUnorderedSet ScComponentManagerCommandInstall::GetAvailableComponents(
{
SC_LOG_DEBUG(
"ScComponentManagerCommandInstall: Validating component \""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ScComponentManagerCommandInstall: Validating component \""
"Validating component \""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants