AO3-4735 Don't treat "-" as NOT when it is alone

otwcode · Sep 28, 2024 · b7ab976 · b7ab976
1 parent f607097
commit b7ab976
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/models/search/query.rb b/app/models/search/query.rb
@@ -237,7 +237,7 @@ def split_query_text_words(fieldname, text)
     str = ""
     return str if text.blank?
     text.split(" ").each do |word|
-      if word[0] == "-"
+      if word.length >= 2 && word[0] == "-"
         str << " NOT"
         word.slice!(0)
       end

diff --git a/spec/models/search/query_spec.rb b/spec/models/search/query_spec.rb
@@ -27,5 +27,11 @@
       result = q.split_query_text_words(:hero, "superman -batman")
       expect(result).to eq(" hero:superman NOT hero:batman")
     end
+
+    it "should not touch stand-alone minuses" do
+      q = Query.new
+      result = q.split_query_text_words(:title, "foo - bar")
+      expect(result).to eq(" title:foo title:\\- title:bar")
+    end
   end
 end