AO3-6010 Add role for Legal #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
suggested changes
Aug 6, 2024
There was a problem hiding this comment.
Two questions regarding mismatches between Jira and what was implemented and a few notes for the tests.
admin_users_controller_spec.rb is missing a few tests:
- test that update doesn't allow legal to change email or roles
- test that update_next_of_kin, update_status, confirm_delete_user_creations, destroy_user_creations doesn't allow the unauthorized admin roles to do changes/access the actions
- activate and troubleshoot aren't testing any roles besides support
4 tasks
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
|
Wait, sorry, I missed my own comment regarding tests in |
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Issue
https://otwarchive.atlassian.net/browse/AO3-6010
Purpose
Add a role for our Legal folks, along with some permissions for that role
Credit
Brian Austin (they/he)