AO3-6772 Create reset_password_instructions mailer preview #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The url is in the form of "https://archiveofourown.org/users/password/edit?reset_password_token=Token" Nothing in this url could become mangled by getting html escaped, it's a standard url and the Token is generated with SecureRandom.urlsafe_base64 without padding, so can only contain A-Z, a-z, 0-9, - and _. So it does not need to be marked as html_safe. Additionally, the admin version of this mail also doesn't call html_safe on the url, neither does devise's own implementation of it.
brianjaustin
approved these changes
Sep 5, 2024
Bilka2
deleted the
AO3-6772-reset-password-instructions-mailer-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6772
Purpose
Create reset_password_instructions mailer preview. Modify devise's mail sending to move the I18n.with_locale call so the locale dropdown in the mailer preview will work.
Testing Instructions
See Jira.
Credit
Bilka (he/him)