Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SSL_renegociate) #10256

Merged
merged 13 commits into from
Apr 15, 2024
Merged

feat(SSL_renegociate) #10256

merged 13 commits into from
Apr 15, 2024

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Apr 14, 2024

What does this PR do?

Allow SSL renegociation for TLSv1.2 on clients

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@Jarred-Sumner
Copy link
Collaborator

Thank you. Can we copy the tests from node?

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Copy link
Contributor

github-actions bot commented Apr 14, 2024

@cirospaciari cirospaciari marked this pull request as ready for review April 14, 2024 06:09
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, only one nitpick.

@Jarred-Sumner Jarred-Sumner merged commit 74d91f6 into main Apr 15, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-renegotiation branch April 15, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants