Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Fix calling Buffer.toString with (offset, length, encoding) #3467

Merged
merged 6 commits into from
Jul 2, 2023
Merged

[WIP]Fix calling Buffer.toString with (offset, length, encoding) #3467

merged 6 commits into from
Jul 2, 2023

Commits on Jun 30, 2023

  1. Allow toString to be called with (offset, length, encoding). 

    Close: oven-sh#3085
    @Hanaasagi
    Hanaasagi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    3b53bba View commit details
    Browse the repository at this point in the history

  2. handle undefined value

    @Hanaasagi
    Hanaasagi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    98be1d9 View commit details
    Browse the repository at this point in the history

  3. add tests for buffer.xxxSlice

    @Hanaasagi
    Hanaasagi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    22a72a9 View commit details
    Browse the repository at this point in the history

  4. fix parameters

    @Hanaasagi
    Hanaasagi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2003ffd View commit details
    Browse the repository at this point in the history

  5. fix offset and length

    @Hanaasagi
    Hanaasagi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    cc0bb2f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Merge branch 'main' into fix-toString

    @Hanaasagi
    Hanaasagi committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    961ec30 View commit details
    Browse the repository at this point in the history