-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make buffer.toString("base64")
4x faster
#3486
Conversation
❌ @Jarred-Sumner 5 files with test failures on linux-x64:
|
❌ @Jarred-Sumner 8 files with test failures on bun-darwin-aarch64:
|
❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:
|
❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:
|
return bigBuffer.toString("base64"); | ||
}); | ||
|
||
// bench("Buffer.from(str, 'base64')", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commented out? Useful benchmark!
This adds https://github.com/aklomp/base64 as a dependency to Bun, which is the same library that Node uses.