Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[install] handle bun add of existing peerDependencies correctly #4028

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

alexlamsl
Copy link
Contributor

What does this PR do?

Previously bun add pkg on the following package.json:

{
  "peerDependencies": {
    "pkg": "^1.2.3"
  }
}

will result in failure, i.e.:

{
  "peerDependencies": {
    "pkg": ""
  }
}

without installing pkg.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I or my editor ran zig fmt on the changed files
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

@Jarred-Sumner Jarred-Sumner merged commit b93f304 into oven-sh:main Aug 7, 2023
15 of 20 checks passed
@Jarred-Sumner
Copy link
Collaborator

Thank you

@alexlamsl alexlamsl deleted the peer-add branch August 7, 2023 00:46
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants