Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dynamically importing bun work #4055

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

await import(eval("'bun')) previously did not work

Now it does, though it only exports bun on the default property because of obscure issues related to the JSC C API which is still partially in use

How did you verify your code works?

Added a test

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

@Jarred-Sumner 3 files with test failures on linux-x64:

  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/esbuild/esbuild-child_process.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#977d9d2aeb5d8ce405293aadd7aca7842b374646

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

@Jarred-Sumner 3 files with test failures on linux-x64-baseline:

  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/esbuild/esbuild-child_process.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#977d9d2aeb5d8ce405293aadd7aca7842b374646

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

@Jarred-Sumner 5 files with test failures on bun-darwin-aarch64:

  • test/js/bun/test/test-test.test.ts
  • test/js/deno/crypto/webcrypto.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/esbuild/esbuild-child_process.test.ts

View test output

#977d9d2aeb5d8ce405293aadd7aca7842b374646

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

@Jarred-Sumner 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/esbuild/esbuild-child_process.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#977d9d2aeb5d8ce405293aadd7aca7842b374646

@Jarred-Sumner Jarred-Sumner merged commit 320ee6b into main Aug 8, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/import-bun branch August 8, 2023 08:42
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant