Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix importing too long of strings #4155

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

paperdave
Copy link
Collaborator

What does this PR do?

Closes #4149 (doesnt fix the underlying problem but the source of the crash)

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

New tests

@github-actions
Copy link
Contributor

@paperdave 3 files with test failures on bun-darwin-aarch64:

  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/watch/fs.watch.test.ts

View test output

#c16e3efdfa8db2aff5fc798f314a84e074ebecbf

@github-actions
Copy link
Contributor

@paperdave 1 files with test failures on linux-x64:

  • test/js/third_party/prisma/prisma.test.ts

View test output

#c16e3efdfa8db2aff5fc798f314a84e074ebecbf

@github-actions
Copy link
Contributor

@paperdave 2 files with test failures on linux-x64-baseline:

  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#c16e3efdfa8db2aff5fc798f314a84e074ebecbf

@github-actions
Copy link
Contributor

@paperdave 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#c16e3efdfa8db2aff5fc798f314a84e074ebecbf

@Jarred-Sumner Jarred-Sumner merged commit 1a6a523 into main Aug 15, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/crash-on-import-long-string branch August 15, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when importing long strings as paths
2 participants