Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add self-closing & can-have-content #4206

Merged
merged 1 commit into from
Aug 19, 2023
Merged

feat: add self-closing & can-have-content #4206

merged 1 commit into from
Aug 19, 2023

Conversation

bru02
Copy link
Contributor

@bru02 bru02 commented Aug 18, 2023

What does this PR do?

adds selfClosing & canHaveContent getters on Element. Also addresses @Jarred-Sumner 's feedback about passing around CallFrames

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I included a test for the new code, or an existing test covers it
  • I added TypeScript types for the new methods, getters, or setters
  • I ran make codegen to regenerate the C++ and Zig code

Jarred-Sumner
Jarred-Sumner approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@Jarred-Sumner Jarred-Sumner merged commit c2ec47f into oven-sh:main Aug 19, 2023
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bru02 @Jarred-Sumner