Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #172 #4220

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Fixes #172 #4220

merged 1 commit into from
Aug 20, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Fixes #172

How did you verify your code works?

Tests

Thanks @rastogishubham

@github-actions
Copy link
Contributor

@Jarred-Sumner 4 files with test failures on bun-darwin-aarch64:

  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#a8c6d4ffc4ed53816d6d5450eb9e604349a3d2ab

@Jarred-Sumner Jarred-Sumner merged commit 1966201 into main Aug 20, 2023
17 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the issue/172 branch August 20, 2023 00:47
@github-actions
Copy link
Contributor

@Jarred-Sumner 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/streams/streams.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#a8c6d4ffc4ed53816d6d5450eb9e604349a3d2ab

@paperdave paperdave mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NapiClass constructor cannot be subclassed
1 participant