New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `emitKeyPresses` with backspace + quote #4245

Merged

Jarred-Sumner merged 1 commit into main from fix-backspace-comma

Aug 22, 2023

Collaborator

paperdave commented Aug 22, 2023 •

edited

Loading

What does this PR do?

Fix backspace then pressing single quote. this is an edge case with prompt libraries like inquirer

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

I tested inquirer manually (writing automated tty tests sucks)


          Fix inquirer

b6122f3

Contributor

github-actions bot commented Aug 22, 2023

❌ @paperdave 2 files with test failures on linux-x64:

test/bundler/esbuild/splitting.test.ts
test/js/third_party/fsevents/fsevents.test.ts

View test output

^{#36f90edb39ebb7b799abe4a20ee38c4a93817c8e}

Contributor

github-actions bot commented Aug 22, 2023

❌ @paperdave 2 files with test failures on linux-x64-baseline:

test/js/third_party/fsevents/fsevents.test.ts
test/js/web/worker.test.ts

View test output

^{#36f90edb39ebb7b799abe4a20ee38c4a93817c8e}

Contributor

github-actions bot commented Aug 22, 2023

❌ @paperdave 7 files with test failures on bun-darwin-aarch64:

test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/dns/node-dns.test.js
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/fsevents/fsevents.test.ts
test/js/web/worker.test.ts

View test output

^{#36f90edb39ebb7b799abe4a20ee38c4a93817c8e}

Contributor

github-actions bot commented Aug 22, 2023

❌ @paperdave 5 files with test failures on bun-darwin-x64-baseline:

test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/node/fs/fs.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#36f90edb39ebb7b799abe4a20ee38c4a93817c8e}

Jarred-Sumner merged commit 91eacad into main

14 of 19 checks passed

Jarred-Sumner deleted the fix-backspace-comma branch

August 22, 2023 02:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet