Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of streams fixes #4251

Merged
merged 36 commits into from
Aug 23, 2023
Merged

Bunch of streams fixes #4251

merged 36 commits into from
Aug 23, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Aug 22, 2023

What does this PR do?

How did you verify your code works?

There are tests

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

✅ test failures on linux-x64-baseline have been resolved.

#daf7e4d5049c5caf47dcc40be40ded76ff305502

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

@cirospaciari 1 files with test failures on linux-x64:

  • test/bundler/esbuild/splitting.test.ts

View test output

#daf7e4d5049c5caf47dcc40be40ded76ff305502

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

@cirospaciari 4 files with test failures on bun-darwin-aarch64:

  • test/js/bun/test/test-test.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/resvg/bbox.test.js

View test output

#daf7e4d5049c5caf47dcc40be40ded76ff305502

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

@cirospaciari 8 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/bundler_compile.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/resvg/bbox.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setInterval.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#daf7e4d5049c5caf47dcc40be40ded76ff305502

@Jarred-Sumner Jarred-Sumner changed the title don't do async hooks stuff when unnecessary Bunch of streams fixes Aug 23, 2023
@Jarred-Sumner Jarred-Sumner merged commit c603857 into main Aug 23, 2023
16 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/wip branch August 23, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadbleStream reads to completion in server, does not stream
2 participants