Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update writing.md - Remove duplicate code snippet #5966

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Update writing.md - Remove duplicate code snippet #5966

merged 1 commit into from
Sep 24, 2023

Conversation

jeroenvanrensen
Copy link
Contributor

@jeroenvanrensen jeroenvanrensen commented Sep 23, 2023 •
edited
Loading

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

samnoon1971
samnoon1971 reviewed Sep 23, 2023
View reviewed changes
Copy link

@samnoon1971 samnoon1971 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I reviewed the files and it seems the duplicate code snippets are removed in writing.md. It would be great if any reviewer could further verify and approve this PR. Thanks

melroy89
melroy89 reviewed Sep 23, 2023
View reviewed changes
Copy link

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Electroid Electroid merged commit 43f0928 into oven-sh:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 left review comments

@samnoon1971 samnoon1971 samnoon1971 left review comments

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeroenvanrensen @melroy89 @Electroid @samnoon1971