Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fetch timeout to 5 minutes #6217

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • Set the default timeout for fetch to 5 minutes instead of 60 seconds

How did you verify your code works?

Existing tests

@Jarred-Sumner
Copy link
Collaborator Author

Fixes #4799
Fixes #5930

@remorses
Copy link

remorses commented Oct 1, 2023

Why do you need a default timeout?

@Jarred-Sumner
Copy link
Collaborator Author

Why do you need a default timeout?

Processes generally shouldn't hang forever. The timeout is not an absolute number, it is since the last time a message was received. You can disable the timeout for fetch with timeout: false

@Jarred-Sumner Jarred-Sumner merged commit b444c0b into main Oct 3, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/increase-timeouts branch October 3, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants