Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn at start when using AVX build of Bun without AVX support #6242

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Oct 2, 2023

What does this PR do?

This PR adds a warning on start when the SIMD-enabled build of Bun is used on a CPU that lacks SIMD support

When using a SIMD-enabled build of Bun when the CPU doesn't support SIMD, Bun may crash with an "Illegal Instruction" error and no other explanation

We detect this in the install scripts, but it doesn't always seem to work and Zig doesn't support multi function versioning (ziglang/zig#1018).

How did you verify your code works?

Manual

@Jarred-Sumner Jarred-Sumner merged commit 89bb526 into main Oct 3, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/warn-cpuid branch October 3, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant