Stop swallowing errors from create_hash_table during the build [take 2] #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If src/codegen/create_hash_table can't be run due to some reason (e.g. due to missing Math::BigInt Perl module) the build continues but fails later, during bindings compilation, because the generated files are empty. Fix it by handling the failure to run create_hash_table properly. Closes #7074
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
…ld (oven-sh#7110) * Stop swallowing errors from create_hash_table during the build If src/codegen/create_hash_table can't be run due to some reason (e.g. due to missing Math::BigInt Perl module) the build continues but fails later, during bindings compilation, because the generated files are empty. Fix it by handling the failure to run create_hash_table properly. Closes oven-sh#7074 * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If src/codegen/create_hash_table can't be run due to some reason (e.g. due to missing Math::BigInt Perl module) the build continues but fails later, during bindings compilation, because the generated files are empty.
Fix it by handling the failure to run create_hash_table properly.
Closes #7074
How did you verify your code works?
By manually testing the build in a minimal Fedora chroot with and without perl-Math-BigInt-GMP package