fix(Bun.serve): return EACCESS when we don't have perms #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error reported to js land when listening fails was always the same, this adds a second one for EACCESS when we are not the super user. Fixes: oven-sh#7187
paperdave
reviewed
Nov 17, 2023
|
nice |
|
@paperdave should be gud now |
paperdave
approved these changes
Nov 18, 2023
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
* fix(Bun.serve): return EACCESS when we don't have perms The error reported to js land when listening fails was always the same, this adds a second one for EACCESS when we are not the super user. Fixes: oven-sh#7187 * fix: adjust code to be only ran on linuz * fix: correct typo * fix: remove comment since its linux only now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error reported to js land when listening fails was always the same, this adds a second one for EACCESS when we are not the super user.
Fixes: #7187
What does this PR do?
How did you verify your code works?
bun-debug test test-file-name.test)