Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is not yet specified package and utils #667

Open
lausdahl opened this issue Feb 20, 2018 · 8 comments
Open

Is not yet specified package and utils #667

lausdahl opened this issue Feb 20, 2018 · 8 comments
Assignees
Labels
enhancement Not a bug, but nice to have language Issues in parser, TC, interpreter, POG or CG
Milestone

Comments

@lausdahl
Copy link
Member

Would it be possible to change the Delegate loading from using no package to a package like org.overture.lib or search default first and then this package?

There are some utility methods like stringOf(Value val) that I keep repeating in different places because I cannot refer IO since it has no package.

The method is also not exposed but thats not a problem to fix if the class just had a package.

I think that leaving these classes without a package isn't the best approach in the first place and I dont think that we would change any backwards compatibility if we just search both for a match.

@lausdahl lausdahl added the enhancement Not a bug, but nice to have label Feb 20, 2018
@nickbattle
Copy link
Contributor

Yes, I like that idea. We would really need to run it past the Language Board, but it is a sensible addition rather than a change.

@peterwvj
Copy link
Member

@nickbattle why do we need to run it past the LB? The way I understand this, it's just an internal change in the Delegate class, isn't it?

@nickbattle
Copy link
Contributor

Well yes, but if we want all future native libs to be in a particular Java package structure, that would have to be added to the packaging guidelines?

@peterwvj
Copy link
Member

Ah yes, I see.

lausdahl added a commit that referenced this issue Mar 1, 2018
@peterwvj peterwvj added this to the v2.6.2 milestone Mar 2, 2018
lausdahl added a commit that referenced this issue Mar 2, 2018
… found in first attempt #667

added missing class check
@lausdahl lausdahl mentioned this issue Mar 6, 2018
@peterwvj
Copy link
Member

peterwvj commented Mar 7, 2018

Okay so it is implemented. Can we close this issue, or do we need to add something on the Language Board library submission workflow page?

@nickbattle
Copy link
Contributor

Or perhaps update the LRM or guides, if they talk about the package structure for native library loading?

@peterwvj
Copy link
Member

peterwvj commented Mar 12, 2018

I can't find anything in the LRM, but there's a related section in the Overture user manual: 16.2 Defining Your Own Java Libraries to be used from Overture. This section describes the naming convention used for packages (>>The Java delegate, if present, has the same name as the VDM module/class name with underscores ("_") replaced with package naming dots (".").<<. We could add an extra paragraph in this section that describes the new loading strategy.

What do you think?

@peterwvj peterwvj modified the milestones: v2.6.2, v2.6.4 May 17, 2018
@peterwvj peterwvj modified the milestones: v2.6.4, v2.6.6 Oct 18, 2018
@peterwvj peterwvj modified the milestones: v2.7.0, v2.7.2 Jun 3, 2019
@peterwvj peterwvj modified the milestones: v2.7.2, v2.7.4 Sep 30, 2019
@nickbattle
Copy link
Contributor

This needs raising with the LB (next year!).

@nickbattle nickbattle added the language Issues in parser, TC, interpreter, POG or CG label Dec 20, 2019
@idhugoid idhugoid modified the milestones: v2.7.4, v3.0.2 Mar 16, 2020
@idhugoid idhugoid modified the milestones: v3.0.0, v3.0.2 Aug 28, 2020
@idhugoid idhugoid modified the milestones: v3.0.2, v3.0.4 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not a bug, but nice to have language Issues in parser, TC, interpreter, POG or CG
Projects
None yet
Development

No branches or pull requests

4 participants