Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IR nodes and cases for ASetPattern and AUnionPattern. #714

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Added IR nodes and cases for ASetPattern and AUnionPattern. #714

merged 1 commit into from
Feb 26, 2020

Conversation

SamieJim
Copy link

Added case methods to pattern visitor for new IR nodes added to IR.ast.

@peterwvj
Copy link
Member

Looks good! Thanks for doing this!

@peterwvj peterwvj merged commit 87e8945 into overturetool:development Feb 26, 2020
@idhugoid idhugoid mentioned this pull request Mar 16, 2020
Open
idhugoid added a commit that referenced this pull request Mar 16, 2020
@idhugoid
Revert "Merge pull request #714 from SamieJim/js/ir"
908057e 
This reverts commit 87e8945, reversing
changes made to 51351ae.

Those commits break the javagen tests according to issue #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamieJim @peterwvj