Skip to content

Commit

Permalink
Fixing incorrect comment in egressip_shared.go
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
  • Loading branch information
alexanderConstantinescu committed Aug 3, 2020
1 parent 025120d commit e0c3ac3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go-controller/pkg/ovn/egressip_shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func deleteNATRule(podIPs []net.IP, status egressipv1.EgressIPStatusItem) error
// we should not really be DNAT-ing here as that would allow an external client direct access to the egress pods.
// EgressIP should only be applied for SNAT-ing traffic.
// GOTCHA 2: whenever this bugs is fixed, be careful and change to:
// util.RunOVNNbctl("lr-nat-del", fmt.Sprintf("GR_%s", status.Node), "dnat_and_snat", podIP.String()) as the ovn-nbctl API is different for snat
// util.RunOVNNbctl("lr-nat-del", fmt.Sprintf("GR_%s", status.Node), "snat", podIP.String()) as the ovn-nbctl API is different for snat
_, stderr, err := util.RunOVNNbctl("lr-nat-del", fmt.Sprintf("GR_%s", status.Node), "dnat_and_snat", status.EgressIP)
if err != nil {
return fmt.Errorf("OVN transaction error, stderr: %s, err: %v", stderr, err)
Expand Down

0 comments on commit e0c3ac3

Please sign in to comment.