-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP: co-exist with UDN when not supported #4593
Open
martinkennelly
wants to merge
4
commits into
ovn-org:master
Choose a base branch
from
martinkennelly:block-udn-eip-sec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkennelly
force-pushed
the
block-udn-eip-sec
branch
from
August 7, 2024 15:04
9d9082b
to
d1f518e
Compare
github-actions
bot
added
the
area/unit-testing
Issues related to adding/updating unit tests
label
Aug 7, 2024
martinkennelly
changed the title
EIP Multi NIC: do not config role primary secondary network namespaces
EIP: do not config when role not primary for a network
Aug 8, 2024
martinkennelly
force-pushed
the
block-udn-eip-sec
branch
from
August 8, 2024 16:00
d1f518e
to
08d8dcc
Compare
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
martinkennelly
force-pushed
the
block-udn-eip-sec
branch
from
August 8, 2024 16:54
08d8dcc
to
2211a2d
Compare
|
martinkennelly
changed the title
EIP: do not config when role not primary for a network
EIP: co-exist with UDN when not supported
Aug 9, 2024
@tssurya can you add this PR to the review list ? |
Yup Wil do can you add the feature labels for udn tp this? |
tssurya
added
the
feature/user-defined-network-segmentation
All PRs related to User defined network segmentation
label
Aug 9, 2024
@tssurya anyone assigned to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/unit-testing
Issues related to adding/updating unit tests
feature/egress-ip
Issues related to EgressIP feature
feature/user-defined-network-segmentation
All PRs related to User defined network segmentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows EIP to co-exist with UDN when EIP doesnt support UDN.
Extracted a few commits from PR #4530
TODO:
Must also skip namespaces with a primary secondary network for the EIP OVN controllerOnce UDN: Add VRF Manager #4548 merges, I also need to block assignment of EIP IPs to a link that is a slave to UDN VRF.