Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP: co-exist with UDN when not supported #4593

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

martinkennelly
Copy link
Member

@martinkennelly martinkennelly commented Aug 7, 2024

This PR allows EIP to co-exist with UDN when EIP doesnt support UDN.

Extracted a few commits from PR #4530

TODO:

  • Must also skip namespaces with a primary secondary network for the EIP OVN controller
  • Once UDN: Add VRF Manager #4548 merges, I also need to block assignment of EIP IPs to a link that is a slave to UDN VRF.

@martinkennelly martinkennelly requested a review from a team as a code owner August 7, 2024 15:01
@github-actions github-actions bot added the area/unit-testing Issues related to adding/updating unit tests label Aug 7, 2024
@martinkennelly martinkennelly changed the title EIP Multi NIC: do not config role primary secondary network namespaces EIP: do not config when role not primary for a network Aug 8, 2024
@github-actions github-actions bot added the feature/egress-ip Issues related to EgressIP feature label Aug 8, 2024
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly
Copy link
Member Author

ovn-ci / e2e (external-gateway, noHA, shared, ipv4, noSnatGW, 2br, ic-single-node-zones) failed with known flake

@martinkennelly martinkennelly changed the title EIP: do not config when role not primary for a network EIP: co-exist with UDN when not supported Aug 9, 2024
@martinkennelly
Copy link
Member Author

@tssurya can you add this PR to the review list ?

@tssurya
Copy link
Member

tssurya commented Aug 9, 2024

Yup Wil do can you add the feature labels for udn tp this?

@tssurya tssurya added the feature/user-defined-network-segmentation All PRs related to User defined network segmentation label Aug 9, 2024
@martinkennelly
Copy link
Member Author

@tssurya anyone assigned to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/unit-testing Issues related to adding/updating unit tests feature/egress-ip Issues related to EgressIP feature feature/user-defined-network-segmentation All PRs related to User defined network segmentation
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants